Lance,
I was testing some more and i saw that the sol output 2 is on when i power on the gpio in PRN, output 2 on is the setting for gear 1, in PRN they both should be off. Also if i go from any gear to PRN the outputs stay on or off in PRN depending on the last gear setting.
Jacco
different input for neutral does not work
-
Bernard Fife
- Posts: 1696
- Joined: Fri Apr 04, 2008 1:28 pm
Re: different input for neutral does not work
Jacco,
Thanks for the feedback and the datalog, I will have a look. It may be something silly like a copy/paste error in the INI. I will get it sorted out and report back here.
Lance.
Thanks for the feedback and the datalog, I will have a look. It may be something silly like a copy/paste error in the INI. I will get it sorted out and report back here.
Lance.
"Never wrestle with pigs. You both get dirty and the pig likes it." - George Bernard Shaw
-
Bernard Fife
- Posts: 1696
- Joined: Fri Apr 04, 2008 1:28 pm
Re: different input for neutral does not work
Jacco,
As I feared, there was a mix-up between the INI and code as to which bits were P and which were N (both report the manual gear as 0, and the current gear as zero, but they ought to be able to have different solenoids active, etc.). The P/N mix-up should be fixed in the attached code and INI:
When P and N were required to be the same, this made no difference. But in generalizing the code, this needs to operate correctly, of course. This code should also fix the issue of the solenoids being turned on appropriately in P and N (assuming the gear lever position can be found correctly, of course).
I still have a few more things to check, but this should be better than older codes. If you want to give it a try, that would be great.
Lance.
As I feared, there was a mix-up between the INI and code as to which bits were P and which were N (both report the manual gear as 0, and the current gear as zero, but they ought to be able to have different solenoids active, etc.). The P/N mix-up should be fixed in the attached code and INI:
When P and N were required to be the same, this made no difference. But in generalizing the code, this needs to operate correctly, of course. This code should also fix the issue of the solenoids being turned on appropriately in P and N (assuming the gear lever position can be found correctly, of course).
I still have a few more things to check, but this should be better than older codes. If you want to give it a try, that would be great.
Lance.
"Never wrestle with pigs. You both get dirty and the pig likes it." - George Bernard Shaw
Re: different input for neutral does not work
Lance,
- the outputs are working fine now
- in N still 99 with the right input code D 10
- with N 3rd input code swapped D still 10 N 25
- what change is in R the current gear indicator is 0 in stat of -1
Datalog Jacco
- the outputs are working fine now
- in N still 99 with the right input code D 10
- with N 3rd input code swapped D still 10 N 25
- what change is in R the current gear indicator is 0 in stat of -1
Datalog Jacco
-
Bernard Fife
- Posts: 1696
- Joined: Fri Apr 04, 2008 1:28 pm
Re: different input for neutral does not work
Okay, thanks for the feedback, I will have a look. Lance.
"Never wrestle with pigs. You both get dirty and the pig likes it." - George Bernard Shaw
-
Bernard Fife
- Posts: 1696
- Joined: Fri Apr 04, 2008 1:28 pm
Re: different input for neutral does not work
Jacco,
I am pretty sure I have finally found the P/N issue now. It is related to the 'missing term' I mentioned above, and has been staring me in face for a few days, but I was too blind to see it. I have it fixed, but I want to do some clean-up of the code before posting it (so that what you are testing closely matches what will be released, hopefully). I will post some updated code here this afternoon that you can try.
I apologize for taking so long on this - I should have spotted this right away.
Lance.
I am pretty sure I have finally found the P/N issue now. It is related to the 'missing term' I mentioned above, and has been staring me in face for a few days, but I was too blind to see it. I have it fixed, but I want to do some clean-up of the code before posting it (so that what you are testing closely matches what will be released, hopefully). I will post some updated code here this afternoon that you can try.
I apologize for taking so long on this - I should have spotted this right away.
Lance.
"Never wrestle with pigs. You both get dirty and the pig likes it." - George Bernard Shaw
-
Bernard Fife
- Posts: 1696
- Joined: Fri Apr 04, 2008 1:28 pm
Re: different input for neutral does not work
Jacco,
Here is the 4.101e test code:
It uses the same INI as the previous code. It should fix the PNR lever determination issue, but I also 'functionalized' the solenoid setting for PNR and made a few other small changes to make the code more efficient, and hopefully I haven't screwed those up. I will be testing it shortly, but if you want to give it a try, that would be great.
If this works, the diagnostics on the dbug output channel will be removed, and it will be released as 4.102 (to avoid confusion with the earlier 4.101 codes from this thread). The code changes will also be rolled-back into 2.100 and released as 2.101. Those will be announced in the 'latest code update' thread in this forum.
Lance.
Here is the 4.101e test code:
It uses the same INI as the previous code. It should fix the PNR lever determination issue, but I also 'functionalized' the solenoid setting for PNR and made a few other small changes to make the code more efficient, and hopefully I haven't screwed those up. I will be testing it shortly, but if you want to give it a try, that would be great.
If this works, the diagnostics on the dbug output channel will be removed, and it will be released as 4.102 (to avoid confusion with the earlier 4.101 codes from this thread). The code changes will also be rolled-back into 2.100 and released as 2.101. Those will be announced in the 'latest code update' thread in this forum.
Lance.
"Never wrestle with pigs. You both get dirty and the pig likes it." - George Bernard Shaw
Re: different input for neutral does not work
Lance,
Yes success.
Jacco
Yes success.
No worries, some times the easy solution take the longest, now we can do some in car road testing. I had the wheels turning and shifting with the wheels of the ground before.I apologize for taking so long on this - I should have spotted this right away.
Jacco
-
Bernard Fife
- Posts: 1696
- Joined: Fri Apr 04, 2008 1:28 pm
Re: different input for neutral does not work
Jacco,
Great! Thanks again for spotting this, bringing it up, and testing - it wouldn't have got fixed without your efforts.
I will be releasing 2.101 and 4.102 code in the 'latest code updates' thread (viewtopic.php?f=4&t=240). These will have PNR the fixes in them, but 4.102 will be functionally the same as 4.101e (except for removing the debug variable).
Lance.
Great! Thanks again for spotting this, bringing it up, and testing - it wouldn't have got fixed without your efforts.
I will be releasing 2.101 and 4.102 code in the 'latest code updates' thread (viewtopic.php?f=4&t=240). These will have PNR the fixes in them, but 4.102 will be functionally the same as 4.101e (except for removing the debug variable).
Lance.
"Never wrestle with pigs. You both get dirty and the pig likes it." - George Bernard Shaw
Re: different input for neutral does not work
Hi to all!! This is my first post, I've just registered to the forum 
I'm Alessandro, from Italy (sorry for my poor english, will make lots of mistakes 
).
So, go to the point:
I'm trying to setup the megashift for a ZF 4HP22, on a Land Rover Discovery... It's almost the same gearbox as the Jacco's 4HP24, except the Range use a different shifter switch. Obviously I have the same problems in detecting the correct gearlever position.
The shifter output pattern is this:
pos / in1 / in2 / in3
P 1 0 0
R 0 1 0
N 1 1 1
D 1 0 1
3 0 1 1
2 0 0 0
1 0 0 1
(0 is for NC; 1 is for 12V)
the switch is a 4 wire output, but I discarded the fourth signal as this way I already obtain 7 different combinations (it would be on only in D,3,2)
I tried the release 2.202... nothing, "-99" error.
This morning tried the 4.103: better results, but error when I shift to R. 1-2-3-N are recognized correctly.
One thing I must try is to enlarge the debounce value: when shifting N-R and R-P the switch make a transition in "1 1 0" status which isn't a regular position, maybe this is the problem...
I also noticed a problem in the led output configuration, maybe things are related to some copy-paste error in the .ini... led 3 shows "ON/OFF/3/4" options and interacts with the led 4, something may be screwed up...
Bye, and compliments to all this good work!!!
Alessandro
I'm Alessandro, from Italy (sorry for my poor english, will make lots of mistakes ). So, go to the point:
I'm trying to setup the megashift for a ZF 4HP22, on a Land Rover Discovery... It's almost the same gearbox as the Jacco's 4HP24, except the Range use a different shifter switch. Obviously I have the same problems in detecting the correct gearlever position.
The shifter output pattern is this:
pos / in1 / in2 / in3
P 1 0 0
R 0 1 0
N 1 1 1
D 1 0 1
3 0 1 1
2 0 0 0
1 0 0 1
(0 is for NC; 1 is for 12V)
the switch is a 4 wire output, but I discarded the fourth signal as this way I already obtain 7 different combinations (it would be on only in D,3,2)
I tried the release 2.202... nothing, "-99" error.
This morning tried the 4.103: better results, but error when I shift to R. 1-2-3-N are recognized correctly.
One thing I must try is to enlarge the debounce value: when shifting N-R and R-P the switch make a transition in "1 1 0" status which isn't a regular position, maybe this is the problem...
I also noticed a problem in the led output configuration, maybe things are related to some copy-paste error in the .ini... led 3 shows "ON/OFF/3/4" options and interacts with the led 4, something may be screwed up...
Bye, and compliments to all this good work!!!
Alessandro